Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style dependencies for 7.48 release #15618

Closed
wants to merge 2 commits into from

Conversation

vivek-datadog
Copy link
Contributor

@vivek-datadog vivek-datadog commented Aug 18, 2023

What does this PR do?

Motivation

Additional Notes

Ignoring black update as seeing lots of failures while updating style dependencies in 15618. To be taken care post 7.48.0-rc.1

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Test Results

       6 files         6 suites   7m 49s ⏱️
   732 tests    727 ✔️   5 💤 0
1 564 runs  1 511 ✔️ 53 💤 0

Results for commit 624f087.

♻️ This comment has been updated with latest results.

@ghost ghost added the dev/tooling label Aug 18, 2023
@vivek-datadog vivek-datadog requested review from a team as code owners August 18, 2023 10:35
@vivek-datadog vivek-datadog force-pushed the vivek-datadog/update-style-dependencies branch from 8be4904 to 594c222 Compare August 18, 2023 10:36
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #15618 (624f087) into master (d205671) will increase coverage by 0.01%.
Report is 371 commits behind head on master.
The diff coverage is 100.00%.

Flag Coverage Δ
datadog_checks_dev 82.51% <100.00%> (+0.07%) ⬆️
ddev 99.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@vivek-datadog
Copy link
Contributor Author

Observing multiple errors, will hold off this pr post 7.48 merge freeze

@vivek-datadog vivek-datadog marked this pull request as draft August 18, 2023 10:43
@vivek-datadog vivek-datadog force-pushed the vivek-datadog/update-style-dependencies branch from 594c222 to 9ce7adc Compare August 18, 2023 13:02
@vivek-datadog vivek-datadog marked this pull request as ready for review August 18, 2023 16:40
@vivek-datadog vivek-datadog marked this pull request as draft August 18, 2023 16:51
@cedricvanrompay-datadog cedricvanrompay-datadog removed the request for review from a team August 22, 2023 13:15
@FlorentClarret
Copy link
Member

Closing this one as it will most likely be done for 7.50

@vivek-datadog vivek-datadog deleted the vivek-datadog/update-style-dependencies branch November 9, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants